Re: [v9.1] sepgsql - userspace access vector cache

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 19. August 2011 16:34
> To: Kohei Kaigai
> Cc: Robert Haas; Kohei KaiGai; Yeb Havinga; PgHacker
> Subject: Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache
>
> Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM> writes:
> > One point I'm worrying about is a case when contrib/sepgsql is compiled
> > with older libselinux than minimum requirement. In this case, we may not
> > notice the broken module unless user tries to load it actually.
> > Is there a good idea to ensure compile failure when we try to build sepgsql
> > module when libselinux-2.0.98 or older was installed?
>
> Well, they should get at least a warning from referencing undefined
> functions, no?
>
Yes. User should notice warning messages due to undefined symbols.
I'm not certain whether it makes sense to add -Werror here, or not.

> There's a limit to how friendly we can be here, since Linux's shlib
> stuff is designed to not require all symbols to be resolvable at shlib
> construction time. This is one place where Darwin works better ...
>
Hmm...
--
NEC Europe Ltd, SAP Global Competence Center
KaiGai Kohei <kohei(dot)kaigai(at)emea(dot)nec(dot)com>