| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [v9.1] sepgsql - userspace access vector cache |
| Date: | 2011-08-19 15:46:07 |
| Message-ID: | 8636.1313768767@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM> writes:
>> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
>> Well, they should get at least a warning from referencing undefined
>> functions, no?
> Yes. User should notice warning messages due to undefined symbols.
> I'm not certain whether it makes sense to add -Werror here, or not.
Hmm. That would help catch the problem, but I'm a bit uncomfortable
with adding -Werror in relatively new code. On the other hand, it's
not like we expect sepgsql to work on a wide variety of systems, so
maybe it'd be OK.
On the whole I don't think it's worth messing with the cflags for this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-08-19 15:47:33 | Re: [v9.1] sepgsql - userspace access vector cache |
| Previous Message | Tom Lane | 2011-08-19 15:40:19 | Re: [v9.1] sepgsql - userspace access vector cache |