Re: Add missing includes

On Mon May 22, 2023 at 10:28 AM CDT, Tom Lane wrote:
> >> Some files were missing information from the c.h header.
>
> > Actually, these omissions are intentional, and we have bespoke handling
> > for this in our own header-checking scripts (src/tools/pginclude). I
> > imagine this is documented somewhere, but ATM I can't remember where.
> > (And if not, maybe that's something we should do.)
>
> Yeah, the general policy is that .h files should not explicitly include
> c.h (nor postgres.h nor postgres_fe.h). Instead, .c files should include
> the appropriate one of those three files first. This allows sharing of
> .h files more easily across frontend/backend/common environments.
>
> I'm not sure where this is documented either.

Thanks for the added context. I'll try to keep this in mind going
forward.

--
Tristan Partin
Neon (https://neon.tech)