From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add missing includes |
Date: | 2023-05-22 15:28:19 |
Message-ID: | 629024.1684769299@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2023-May-22, Tristan Partin wrote:
>> Some files were missing information from the c.h header.
> Actually, these omissions are intentional, and we have bespoke handling
> for this in our own header-checking scripts (src/tools/pginclude). I
> imagine this is documented somewhere, but ATM I can't remember where.
> (And if not, maybe that's something we should do.)
Yeah, the general policy is that .h files should not explicitly include
c.h (nor postgres.h nor postgres_fe.h). Instead, .c files should include
the appropriate one of those three files first. This allows sharing of
.h files more easily across frontend/backend/common environments.
I'm not sure where this is documented either.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tristan Partin | 2023-05-22 15:32:36 | Re: Add missing includes |
Previous Message | Tristan Partin | 2023-05-22 15:27:37 | Re: Add missing includes |