Re: Typo in PL/pgSQL trigger Example 43.4?

> On 7 Oct 2023, at 22:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
>> On Sat, Oct 7, 2023 at 11:11 AM Kirk Parker <khp(at)equatoria(dot)us> wrote:
>>> INSERT INTO emp_audit SELECT 'D', now(), user, OLD.*; -- <= ARGUMENT IN QUESTION
>>> The emp_audit table has a column named 'userid', which in actual usage
>>> (next-to-last line quoted) is populated by 'user' which seems undefined in
>>> the context. Was that intended to be 'current_user', or am I missing
>>> something?
>
>> user is a valid pseudo-function:
>> https://www.postgresql.org/docs/current/functions-info.html#FUNCTIONS-INFO-SESSION
>
> Yeah, either way has the same result. However, I wonder if we should
> change this example to use current_user for clarity. It does look
> more like it's intended to be a variable or column reference than
> a built-in function.

Agreed, and "user" is a hard search term to use for discovering what it is. +1
for changing to current_user.

--
Daniel Gustafsson