| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: unnesting multirange data types |
| Date: | 2021-06-15 18:46:26 |
| Message-ID: | CAPpHfdvgmQwSHeFVuNofdmU1ti1GUkBza5qJoKEVwNjcqiLkpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 15, 2021 at 8:18 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > I did run "check-world", but it passed for me. Probably the same
> > reason it passed for some buildfarm animals...
>
> The only buildfarm animals that have passed since this went in
> are the ones that don't run the pg_dump or pg_upgrade tests.
>
> It looks to me like the proximate problem is that you should
> have taught pg_dump to skip these new auto-generated functions.
> However, I fail to see why we need auto-generated functions
> for this at all. Couldn't we have done it with one polymorphic
> function?
>
> I think this ought to be reverted and reviewed more carefully.
Thank you for your feedback. I've reverted the patch.
I'm going to have closer look at this tomorrow.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2021-06-15 18:47:40 | Re: unnesting multirange data types |
| Previous Message | Andrew Dunstan | 2021-06-15 18:43:51 | Re: unnesting multirange data types |