Re: [PATCH]make pg_rewind to not copy useless WAL files

Hi!

On Sat, Sep 16, 2017 at 5:56 PM, chenhj <chjischj(at)163(dot)com> wrote:

> This patch optimizes the above mentioned issues, as follows:
> 1. In the target data directory, do not delete the WAL files before the
> divergence.
> 2. When copying files from the source server, do not copy the WAL files
> before the divergence and the WAL files after the current WAL insert
> localtion.
>

Looks like cool optimization for me. Please, add this patch to the next
commitfest.
Do you think this patch should modify pg_rewind tap tests too? It would be
nice to make WAL files fetching more covered by tap tests. In particular,
new tests may generate more WAL files and make sure that pg_rewind fetches
only required files among them.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company