| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| Date: | 2017-09-16 18:26:34 |
| Message-ID: | 20170916182634.blb7upixw7hosdhu@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2017-09-16 10:32:29 -0400, Tom Lane wrote:
> It's dying at "pfree(localControlFile)". localControlFile seems to
> be pointing at a region of memory that's entirely zeroes; certainly
> the data that it just moved into shared memory is all zeroes.
> It looks like someone didn't think hard enough about when to reset
> ControlFile to null.
Yep. Just adding a LocalProcessControlFile() reset_shared() works after
removing the assert from LocalProcessControlFile(). That's not what I'm
proposing, just confirming that that's the issue.
Looking into it.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-16 18:30:21 | Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| Previous Message | Tom Lane | 2017-09-16 17:20:51 | pgsql: Fix SQL-spec incompatibilities in new transition table feature. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-16 18:30:21 | Re: Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup. |
| Previous Message | Alexander Korotkov | 2017-09-16 18:19:46 | Re: [PATCH]make pg_rewind to not copy useless WAL files |