From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Introduce hash_search_with_hash_value() function |
Date: | 2024-08-07 20:08:00 |
Message-ID: | CAPpHfdvBmr-Fn38MprJhzNTBSLDfa3Bd9o6YwL_MF_v=Q4gRBg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Aug 7, 2024 at 7:30 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Aug 7, 2024 at 11:55 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > On Wed, Aug 7, 2024 at 3:24 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > > You may have already realized this, but the name of the function the
> > > patch adds is not the same as the name that appears in the commit
> > > message.
> >
> > :sigh:
> > I didn't realize that before your message. That would be another item
> > for my checklist: ensure entities referenced from commit message and
> > comments didn't change their names.
>
> I really wish there was some way to fix commit messages. I had a typo
> in mine today, too.
+1,
One of the scariest things that happened to me was forgetting to
mention reviewers or even authors. People don't get credit for their
work, and you can't fix that.
------
Regards,
Alexander Korotkov
Supabase
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2024-08-07 20:08:45 | Re: pgsql: Introduce hash_search_with_hash_value() function |
Previous Message | Alexander Korotkov | 2024-08-07 20:04:59 | Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe |
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2024-08-07 20:08:45 | Re: pgsql: Introduce hash_search_with_hash_value() function |
Previous Message | Melanie Plageman | 2024-08-07 19:39:49 | Re: Add LSN <-> time conversion functionality |