Re: pgsql: Introduce hash_search_with_hash_value() function

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Introduce hash_search_with_hash_value() function
Date: 2024-08-07 20:08:45
Message-ID: CAPpHfdtY2sF4YoQMnUEckutrQEzwoYSh-mCjTQRSsTk8d+Dkqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Aug 7, 2024 at 9:01 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Aug 7, 2024 at 1:15 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> > > We could use git notes. The UI is a bit inconvenient (they have to be
> > > pushed and pulled separately from commits), but they seem useful enough.
> >
> > Yeah, I spend a lot of time on commit messages because they're pretty much
> > written in stone once pushed. I'd definitely use git notes to add errata,
> > follow-up commits that fixed/reverted things, etc.
>
> I think this could be a good idea, although it wouldn't really fix the
> problem, because in the case of both this commit and the one I
> mentioned earlier today, all you could do with the note is point out
> the earlier mistake. You couldn't actually fix it.

Correct, but something looks better than nothing.

> Also, for the notes to be useful, we'd probably need some conventions
> about how we, as a project, want to use them. If everyone does
> something different, the result isn't likely to be all that great.

+1

------
Regards,
Alexander Korotkov
Supabase

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-08-07 20:25:12 Re: pgsql: Introduce hash_search_with_hash_value() function
Previous Message Alexander Korotkov 2024-08-07 20:08:00 Re: pgsql: Introduce hash_search_with_hash_value() function

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-08-07 20:10:27 Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs
Previous Message Alexander Korotkov 2024-08-07 20:08:00 Re: pgsql: Introduce hash_search_with_hash_value() function