Re: pgsql: Make all Perl warnings fatal

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make all Perl warnings fatal
Date: 2023-12-29 22:17:22
Message-ID: CAPpHfdv31WnqELu6ZxE6fS-TqtQMAqLA9AWbK3=CvQBokLj_-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Dec 29, 2023 at 10:13 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> On Fri, 2023-12-29 at 17:46 +0000, Peter Eisentraut wrote:
> > Make all Perl warnings fatal
>
> This seems to be causing problems in the buildfarm:
>
> Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
> (m//) at t/001_mutated_bindpasswd.pl line 23.

It seems to cause failures for many buildfarm machines. Also, on my local
Macbook I got the following error.

# +++ tap check in src/interfaces/libpq +++
t/001_uri.pl ..................... ok
t/002_api.pl ..................... ok
t/003_load_balance_host_list.pl .. ok
t/004_load_balance_dns.pl ........ Dubious, test returned 25 (wstat 6400,
0x1900)
No subtests run

Test Summary Report
-------------------
t/004_load_balance_dns.pl (Wstat: 6400 Tests: 0 Failed: 0)
Non-zero exit status: 25
Parse errors: No plan found in TAP output
Files=4, Tests=188, 4 wallclock secs ( 0.04 usr 0.01 sys + 0.98 cusr
1.68 csys = 2.71 CPU)
Result: FAIL
make: *** [check] Error 1

------
Regards,
Alexander Korotkov

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-12-29 22:41:56 Re: pgsql: Make all Perl warnings fatal
Previous Message Jeff Davis 2023-12-29 20:13:41 Re: pgsql: Make all Perl warnings fatal