Re: pgsql: Make all Perl warnings fatal

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make all Perl warnings fatal
Date: 2023-12-29 22:41:56
Message-ID: 3261739.1703889716@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> On Fri, Dec 29, 2023 at 10:13 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>> This seems to be causing problems in the buildfarm:
>> Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
>> (m//) at t/001_mutated_bindpasswd.pl line 23.

> It seems to cause failures for many buildfarm machines.

Presumably, exactly the ones that don't set PG_TEST_EXTRA :-(.
Peter would not have noticed this if he keeps that set in his
test environment.

The fix looks simple enough, although a bit tedious because there
are a bunch of places to change. I can have a go at it if no-one
else is already on it?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-12-29 22:56:11 pgsql: Follow-up fixes for "Make all Perl warnings fatal"
Previous Message Alexander Korotkov 2023-12-29 22:17:22 Re: pgsql: Make all Perl warnings fatal