Re: Missing docs for new enable_group_by_reordering GUC

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Cc: Andrei Lepikhov <lepihov(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing docs for new enable_group_by_reordering GUC
Date: 2024-06-19 19:35:49
Message-ID: CAPpHfdugtpt3u_cA9wJKqiGURyN+mSXhnJ2QZc6fESTCwwtqNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 19, 2024 at 6:02 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> On Wed, 19 Jun 2024 at 05:27, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>>
>> On Tue, Jun 18, 2024 at 4:14 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>> >> Controls if the query planner will produce a plan which will provide <literal>GROUP BY</literal> keys presorted in the order of keys of a child node of the plan, such as an index scan. When disabled, the query planner will produce a plan with <literal>GROUP BY</literal> keys only reordered to match
>> >> the <literal>ORDER BY</literal> clause, if any. When enabled, the planner will try to produce a more efficient plan. The default value is on.
>> > A correction of myself: presorted -> sorted, reordered ->sorted
>>
>> Thank you for your review. I think all of this make sense. Please,
>> check the revised patch attached.
>
> To me patch v3 looks good.

Ok, thank you. I'm going to push this if no objections.

------
Regards,
Alexander Korotkov
Supabase

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2024-06-19 20:00:00 Re: Failures in constraints regression test, "read only 0 of 8192 bytes"
Previous Message Nathan Bossart 2024-06-19 19:24:08 Re: remove check hooks for GUCs that contribute to MaxBackends