Re: Missing docs for new enable_group_by_reordering GUC

From: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Andrei Lepikhov <lepihov(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing docs for new enable_group_by_reordering GUC
Date: 2024-06-19 15:02:19
Message-ID: CALT9ZEHjf_ub6qory48WRA615OPJx+PLDweCpnNycHPKZpu0kQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Alexander!

On Wed, 19 Jun 2024 at 05:27, Alexander Korotkov <aekorotkov(at)gmail(dot)com>
wrote:

> On Tue, Jun 18, 2024 at 4:14 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
> wrote:
> >> Controls if the query planner will produce a plan which will provide
> <literal>GROUP BY</literal> keys presorted in the order of keys of a child
> node of the plan, such as an index scan. When disabled, the query planner
> will produce a plan with <literal>GROUP BY</literal> keys only reordered to
> match
> >> the <literal>ORDER BY</literal> clause, if any. When enabled, the
> planner will try to produce a more efficient plan. The default value is on.
> > A correction of myself: presorted -> sorted, reordered ->sorted
>
> Thank you for your review. I think all of this make sense. Please,
> check the revised patch attached.
>
To me patch v3 looks good.

Regards,
Pavel Borisov
Supabase

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-06-19 15:03:37 Re: Logical Replication of sequences
Previous Message Srirama Kucherlapati 2024-06-19 14:55:47 RE: AIX support