From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST |
Date: | 2019-09-19 20:43:56 |
Message-ID: | CAPpHfduVKNxSmJ8Udgrcq+O5yDf8TCm--gdF52EXN-EZGvoBoQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Thu, Sep 19, 2019 at 11:31 PM Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> On Thu, Sep 19, 2019 at 11:13 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Erik Rijkers <er(at)xs4all(dot)nl> writes:
>> > Oops:
>> > create_index ... ok 634 ms
>> > create_index_spgist ... FAILED 438 ms
>> > create_view ... ok 329 ms
>>
>> I'm betting the issue is breaking the Datum abstraction here:
>>
>> - scan->xs_orderbyvals[i] = Float8GetDatum(distanceValues[i]);
>> + scan->xs_orderbyvals[i] = item->distances[i].value;
>
>
> Overseen by me. Will fix immediately.
Fix pushed from 11 to 9.5, where I made this error during backpatching.
However, I also see set of failures in master, which seems related to
this patch:
* https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2019-09-19%2020%3A09%3A42
* https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2019-09-19%2020%3A04%3A22
* https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2019-09-19%2019%3A22%3A01
Will investigate them.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2019-09-19 20:47:43 | Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST |
Previous Message | Alexander Korotkov | 2019-09-19 20:41:09 | pgsql: Fix oversight in backpatch of 6cae9d2c10 |