| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST |
| Date: | 2019-09-19 20:31:31 |
| Message-ID: | CAPpHfdu+ZSp2rB0KOKYb971sfjGgOs20ACmna0ZMb4EiU=woTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Sep 19, 2019 at 11:13 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Erik Rijkers <er(at)xs4all(dot)nl> writes:
> > Oops:
> > create_index ... ok 634 ms
> > create_index_spgist ... FAILED 438 ms
> > create_view ... ok 329 ms
>
> I'm betting the issue is breaking the Datum abstraction here:
>
> - scan->xs_orderbyvals[i] =
> Float8GetDatum(distanceValues[i]);
> + scan->xs_orderbyvals[i] = item->distances[i].value;
>
Overseen by me. Will fix immediately.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2019-09-19 20:40:31 | pgsql: Fix oversight in backpatch of 6cae9d2c10 |
| Previous Message | Tom Lane | 2019-09-19 20:13:37 | Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST |