| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Access method extendability |
| Date: | 2016-03-31 15:29:37 |
| Message-ID: | CAPpHfdtqeXkqZ56aRikDXCUjV+PW6AZa8tiihYsLO1P4iAFF2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
New revision of patches is attached.
Changes are following:
1) API of generic xlog was changed: now there is no static variables,
GenericXLogStart()
returns palloc'd struct.
2) Generic xlog use elog instead ereport since it reports internal errors
which shouldn't happen normally.
3) Error messages doesn't contains name of the function.
4) Bloom contrib was pgindented.
5) More comments for bloomb.
6) One more assert was added to bloom.
7) makeDefaultBloomOptions was renamed to adjustBloomOptions. Now it only
modifies its parameter. palloc is done outside of this function.
8) BloomBuildState is explicitly zeroed.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-generic-xlog.15.patch | application/octet-stream | 25.5 KB |
| 0003-bloom-contrib.15.patch | application/octet-stream | 61.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2016-03-31 15:44:35 | Re: So, can we stop supporting Windows native now? |
| Previous Message | Alvaro Herrera | 2016-03-31 14:18:46 | Re: Correction for replication slot creation error message in 9.6 |