Re: Removing unneeded self joins

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Andrei Lepikhov <lepihov(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Subject: Re: Removing unneeded self joins
Date: 2025-02-26 12:12:30
Message-ID: CAPpHfdt=f7ZOnaH+DjkxYYgmsZE7i1KChHCqrMd9SwzOMBt__Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 24, 2025 at 12:57 PM Alexander Korotkov
<aekorotkov(at)gmail(dot)com> wrote:
> On Mon, Feb 24, 2025 at 12:12 AM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> > On 23/2/2025 22:15, Alexander Korotkov wrote:
> > > There is my attempt to implement this approach. Getting rid of local
> > > variable (and computation of the same value other way) required to
> > > change arguments of remove_rel_from_eclass() as well. I'm going to
> > > further polish this tomorrow.
> > I passed through the patch. It works correctly.
> >
> > Multiple ifs in a single routine is not ideal.
>
> I would say there is a brachcing anyway. Even if it is inside
> adjust_relid_set(). Patch makes it more explicit. Ideal or not, I
> don't think it gets worse.

I've added a commit message to the patch. I'm going to push it if no
objections.

------
Regards,
Alexander Korotkov
Supabase

Attachment Content-Type Size
v2-0001-Get-rid-of-ojrelid-local-variable-in-remove_rel_f.patch application/octet-stream 8.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-02-26 12:14:31 Re: Removing unneeded self joins
Previous Message Nisha Moond 2025-02-26 12:10:00 Race condition in replication slot usage introduced by commit f41d846