| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Subject: | Re: postgres.h included from relcache.h - but removing it breaks pg_upgrade |
| Date: | 2021-09-19 15:45:45 |
| Message-ID: | CAPpHfdst2XnxoQt_rw+ZrFHSyXXTUosE3rhc5+Qcj4OobKG66g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 18, 2021 at 11:35 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2021-Sep-18, Alexander Korotkov wrote:
>
> > I see now. I think I'm rather favoring splitting visibilitymap.h.
>
> Agreed, this looks sane to me. However, I think the
> VM_ALL_{VISIBLE,FROZEN} macros should remain in visibilitymap.h, since
> they depend on the visibilitymap_get_status function (and pg_upgrade
> doesn't use them).
>
> There's a typo "maros" for "macros" in the new header file. (Also, why
> does the copyright line say "portions" if no portion under another
> copyright? I think we don't say "portions" when there is only one
> copyright statement line.)
Thank you for the feedback. All changes are accepted.
Any objections to pushing this?
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Split-macros-from-visibilitymap.h-into-a-separate--3.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-09-19 16:32:01 | Re: Release 14 Schedule |
| Previous Message | Tom Lane | 2021-09-19 14:56:08 | Re: Undocumented AT TIME ZONE INTERVAL syntax |