| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>, Alexander Law <exclusion(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Subject: | Re: BUG #17066: Cache lookup failed when null (unknown) is passed as anycompatiblemultirange |
| Date: | 2021-07-27 15:34:10 |
| Message-ID: | CAPpHfdsb4jsVDWsajAMK032vw2vqUHPaXL02xsuK=zy7FZ1trw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jul 21, 2021 at 12:54 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > Do I understand correctly that enforce_generic_type_consistency() is
> > called only after check_generic_type_consistency() returned true?
> > If so, that means some of the checks are redundant. Therefore, we can
> > replace ereport()'s with Assert()'s.
>
> They are not redundant, IIRC. I forget the exact mechanism for
> reaching them, but it likely has something to do with aggregates
> or variadic functions.
>
> In any case, apologies for taking so long to get back to this. Here's
> a proposed patch (based in part on Neil's earlier patch).
This patch looks good to me. Besides fixing the particular bug
report, it seems that the situation of mismatching range and
multirange types in arguments is now handled correctly.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-27 15:38:07 | Re: BUG #17066: Cache lookup failed when null (unknown) is passed as anycompatiblemultirange |
| Previous Message | Alexander Korotkov | 2021-07-27 15:31:05 | Re: BUG #17066: Cache lookup failed when null (unknown) is passed as anycompatiblemultirange |