Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution
Date: 2021-12-22 05:40:45
Message-ID: CAPmGK15okvN_NNOzY_34m+zgXW_cNkSCHJfqkKNncYeuhzvwgQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Alexander,

On Wed, Dec 22, 2021 at 1:08 AM Alexander Pyhalov
<a(dot)pyhalov(at)postgrespro(dot)ru> wrote:
> Etsuro Fujita писал 2021-12-19 13:25:
> > While working on [1], I noticed $SUBJECT: postgres_fdw resets the
> > per-connection states of connections, which store async requests sent
> > to remote servers in async_capable mode, during post-abort
> > (pgfdw_xact_callback()), but it fails to do so during post-subabort
> > (pgfdw_subxact_callback()). This causes a crash when re-executing a
> > query that was aborted in a subtransaction:

> Looks good to me.

Great! Thanks for reviewing!

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2021-12-22 05:46:21 Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Previous Message Pavel Stehule 2021-12-22 05:21:41 Re: Schema variables - new implementation for Postgres 15