Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution

From: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: incomplete subabort cleanup of connections used in async execution
Date: 2021-12-21 16:08:26
Message-ID: 0cdfea8348fac30e225a010ee36b3ce0@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Etsuro Fujita писал 2021-12-19 13:25:
> Hi,
>
> While working on [1], I noticed $SUBJECT: postgres_fdw resets the
> per-connection states of connections, which store async requests sent
> to remote servers in async_capable mode, during post-abort
> (pgfdw_xact_callback()), but it fails to do so during post-subabort
> (pgfdw_subxact_callback()). This causes a crash when re-executing a
> query that was aborted in a subtransaction:
>

Hi.
Looks good to me.
--
Best regards,
Alexander Pyhalov,
Postgres Professional

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-12-21 17:23:25 Re: Emit a warning if the extension's GUC is set incorrectly
Previous Message osumi.takamichi@fujitsu.com 2021-12-21 14:17:31 RE: Optionally automatically disable logical replication subscriptions on error