Re: postgres_fdw: Useless if-test in GetConnection()

On Wed, Mar 15, 2023 at 7:40 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Wed, Mar 15, 2023 at 6:18 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>> While working on something else, I noticed that the “if (entry->conn
>> == NULL)” test after doing disconnect_pg_server() when re-establishing
>> a given connection in GetConnection() is pointless, because the former
>> function ensures that entry->conn is NULL. So I removed the if-test.
>> Attached is a patch for that. I think we could instead add an
>> assertion, but I did not, because we already have it in
>> make_new_connection().

> +1. Good catch.

Cool! Thanks for looking!

Best regards,
Etsuro Fujita