Re: postgres_fdw: Useless if-test in GetConnection()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: Useless if-test in GetConnection()
Date: 2023-03-15 10:40:00
Message-ID: CAMbWs4-G59FBY7gA06c+wW7j+3=WBS5J6s1vXJsjfBsEJsCeJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 15, 2023 at 6:18 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
wrote:

> While working on something else, I noticed that the “if (entry->conn
> == NULL)” test after doing disconnect_pg_server() when re-establishing
> a given connection in GetConnection() is pointless, because the former
> function ensures that entry->conn is NULL. So I removed the if-test.
> Attached is a patch for that. I think we could instead add an
> assertion, but I did not, because we already have it in
> make_new_connection().

+1. Good catch.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2023-03-15 10:45:58 Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Previous Message Peter Eisentraut 2023-03-15 10:36:02 Re: TAP output format in pg_regress