Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
Subject: Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails
Date: 2021-07-15 09:35:33
Message-ID: CAPmGK15KFjpiHcu+fLVOJzH=41gTgTOqbbaUSwib1CKX0io69A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Jul 15, 2021 at 4:17 AM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> On Wed, Jul 14, 2021 at 1:41 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Seems to just need an update of the expected-file to account for test
>> cases added recently. (I take no position on whether the new results
>> are desirable; some of these might be breaking the intent of the case.
>> But this should quiet the cfbot anyway.)

> The test case was added by commit "Add support for asynchronous execution"
> "27e1f14563cf982f1f4d71e21ef247866662a052" by Etsuro Fujita. He can comment
> whether the new results are desirable or not.

The new results aren't what I intended. I'll update the patch to
avoid that by modifying the original test cases properly, if there are
no objections.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Pawel Kudzia 2021-07-15 09:38:04 Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows
Previous Message Etsuro Fujita 2021-07-15 09:15:24 Re: BUG #16631: postgres_fdw tries to insert into generated columns

Browse pgsql-hackers by date

  From Date Subject
Next Message tanghy.fnst@fujitsu.com 2021-07-15 09:46:18 [PATCH] Add tab-complete for backslash commands
Previous Message Andy Fan 2021-07-15 09:33:53 Re: Keep notnullattrs in RelOptInfo (Was part of UniqueKey patch series)