Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails

From: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
Subject: Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails
Date: 2021-07-15 13:02:28
Message-ID: CALtqXTf_WzXVKKMBzdrCkLjxVXLmgOuiycf83UQ=8E=WHdchMA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Jul 15, 2021 at 2:35 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
wrote:

> On Thu, Jul 15, 2021 at 4:17 AM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> > On Wed, Jul 14, 2021 at 1:41 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Seems to just need an update of the expected-file to account for test
> >> cases added recently. (I take no position on whether the new results
> >> are desirable; some of these might be breaking the intent of the case.
> >> But this should quiet the cfbot anyway.)
>
> > The test case was added by commit "Add support for asynchronous
> execution"
> > "27e1f14563cf982f1f4d71e21ef247866662a052" by Etsuro Fujita. He can
> comment
> > whether the new results are desirable or not.
>
> The new results aren't what I intended. I'll update the patch to
> avoid that by modifying the original test cases properly, if there are
> no objections.
>
> Best regards,
> Etsuro Fujita
>

Thanks Etsuro,

I have changed the status to "Waiting On Author", because patch need
changes.
Etsuro, can you make yourself a reviewer/co-author to keep track of that?

--
Ibrar Ahmed

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Pawel Kudzia 2021-07-15 13:27:08 Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows
Previous Message PG Bug reporting form 2021-07-15 11:58:12 BUG #17110: [FEATURE REQUEST] Log all plans for a query instead of just showing the most optimal plan

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2021-07-15 13:04:14 Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)
Previous Message Ronan Dunklau 2021-07-15 13:02:00 Re: Add proper planner support for ORDER BY / DISTINCT aggregates