Re: BUG #17344: Assert failed on queiring async_capable foreign table with inheritance

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17344: Assert failed on queiring async_capable foreign table with inheritance
Date: 2022-01-07 06:15:56
Message-ID: CAPmGK14UU-qKKHLhL4-rgxJg6zMtccbkj8diqSwX_o=hWdU1gA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi Alexander,

On Mon, Jan 3, 2022 at 4:00 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> 31.12.2021 10:36, Etsuro Fujita wrote:
> > To fix, I modified postgresReScanForeignScan() so that we always
> > process a pending async request (if any) before restarting the foreign
> > scan. Attached is a patch for that. I tested the patch with the
> > first case, and it addresses the assertion failure.

> Thanks for the fix! I can confirm that it eliminates the failure and

Good to know. Thanks for testing!

> propose a simple test case for the issue. Maybe you will find it useful.

Thanks, but in my environment, the test case doesn’t cause any
failure. How about something like the attached, which is made by
modifying the original test case to avoid the connection-limit-error
issue. In the attached, I also added a comment to a function to match
other places.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
fix-postgres-fdw-async-rescan-2.patch application/octet-stream 4.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Etsuro Fujita 2022-01-07 06:19:46 Re: BUG #17355: Server crashes on ExecReScanForeignScan in postgres_fdw when accessing foreign partition
Previous Message David G. Johnston 2022-01-07 01:30:01 Re: Possible bug report