| From: | RekGRpth <rekgrpth(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c |
| Date: | 2023-12-07 02:28:02 |
| Message-ID: | CAPgh2mKNpTfMJ7G3QF_cxLDsvQzMDGc2-XoL41oajt5VgO5ZNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Fixed!
чт, 7 дек. 2023 г. в 06:52, Richard Guo <guofenglinux(at)gmail(dot)com>:
>
>
> On Thu, Dec 7, 2023 at 12:41 AM RekGRpth <rekgrpth(at)gmail(dot)com> wrote:
>>
>> Fixed!
>
>
> Nice catch.
>
> There are several places in DecodeDateTime() where the value of '*tzp'
> is changed. It seems to me that these assignments are unnecessary since
> the value of '*tzp' is not utilized anywhere in the code. Can we also
> remove these assignments?
>
> Thanks
> Richard
| Attachment | Content-Type | Size |
|---|---|---|
| tz.diff | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-12-07 02:32:33 | Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c |
| Previous Message | Richard Guo | 2023-12-07 01:51:57 | Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c |