Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: RekGRpth <rekgrpth(at)gmail(dot)com>
Cc: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
Date: 2023-12-07 01:51:57
Message-ID: CAMbWs48z_7Vc8_Q93QEuUaB6n3-rJPO0f8KF=gbogzTmK4hvpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Dec 7, 2023 at 12:41 AM RekGRpth <rekgrpth(at)gmail(dot)com> wrote:

> Fixed!

Nice catch.

There are several places in DecodeDateTime() where the value of '*tzp'
is changed. It seems to me that these assignments are unnecessary since
the value of '*tzp' is not utilized anywhere in the code. Can we also
remove these assignments?

Thanks
Richard

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message RekGRpth 2023-12-07 02:28:02 Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c
Previous Message Laurenz Albe 2023-12-06 21:01:58 Re: BUG #18230: Redundant comparison of a local variable 'tzp' address with a NULL value at dt_common.c