Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

From: Mishika Singh <mishikaps(at)gmail(dot)com>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch to contribute in pgAdmin to increase the maximum length of the server password
Date: 2020-06-15 10:57:50
Message-ID: CAPMi4M5SmyTnx85Ze3-1YibW7rpuiSH1HmkoFs1NOxNHmgMjDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya,

I am part of Adobe Experience Platform - Query Service team. Query Service
uses the Postgres protocol to query data in Platform. We have enabled a
variety of client applications to connect to Query Service like Aqua Data
Studio, Power BI, Tableau. [
https://docs.adobe.com/content/help/en/experience-platform/query/clients/overview.html
]
Length of the password to connect to query service is more than 1000
characters.

On Mon, Jun 15, 2020 at 3:55 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Mishika,
>
> The patch looks good to me. Just out of curiosity, what is the use case
> where the password is more than 1000 characters ? :O
>
> On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh <mishikaps(at)gmail(dot)com> wrote:
>
>> Thanks Aditya for looking into this. I have done the changes noting
>> your suggestion to pass the maxLength param for the password field.
>> PFA of the patch for the same.
>>
>> On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
>> <aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>> >
>> > Hi Mishika,
>> >
>> > You've changed the defaults directly which will change the maxLength
>> for all the text boxes across pgAdmin.
>> > If you want to change the maxLength for the server dialog password
>> field then you can pass the maxLength param for the password field. This
>> will affect the password field only without affecting others.
>> >
>> >
>> > On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh <mishikaps(at)gmail(dot)com>
>> wrote:
>> >>
>> >> Hi Team,
>> >>
>> >> I have created an issue :https://redmine.postgresql.org/issues/5592.
>> >> In pgAdmin4 there is a restriction on the password length while trying
>> >> to connect to the server, the limit is 255. We have use cases where
>> >> the password length is more than that.
>> >>
>> >> PFA of the patch to increase the maximum length.
>> >>
>> >> --
>> >> Regards
>> >> Mishika Singh
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> > "Don't Complain about Heat, Plant a TREE"
>>
>>
>>
>> --
>> Regards
>>
>> Mishika Singh
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Regards
Mishika Singh

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-06-15 11:11:23 Re: Patch for SonarQube UI fixes.
Previous Message Nikhil Mohite 2020-06-15 10:51:55 Patch for SonarQube UI fixes.