Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Mishika Singh <mishikaps(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch to contribute in pgAdmin to increase the maximum length of the server password
Date: 2020-06-15 10:24:45
Message-ID: CAM9w-_=YAZWbHExFuMNiVZ5SSCzC1fJGuvOMyf05R=EARGiGPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Mishika,

The patch looks good to me. Just out of curiosity, what is the use case
where the password is more than 1000 characters ? :O

On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh <mishikaps(at)gmail(dot)com> wrote:

> Thanks Aditya for looking into this. I have done the changes noting
> your suggestion to pass the maxLength param for the password field.
> PFA of the patch for the same.
>
> On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
> <aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> >
> > Hi Mishika,
> >
> > You've changed the defaults directly which will change the maxLength for
> all the text boxes across pgAdmin.
> > If you want to change the maxLength for the server dialog password field
> then you can pass the maxLength param for the password field. This will
> affect the password field only without affecting others.
> >
> >
> > On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh <mishikaps(at)gmail(dot)com>
> wrote:
> >>
> >> Hi Team,
> >>
> >> I have created an issue :https://redmine.postgresql.org/issues/5592.
> >> In pgAdmin4 there is a restriction on the password length while trying
> >> to connect to the server, the limit is 255. We have use cases where
> >> the password length is more than that.
> >>
> >> PFA of the patch to increase the maximum length.
> >>
> >> --
> >> Regards
> >> Mishika Singh
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> > "Don't Complain about Heat, Plant a TREE"
>
>
>
> --
> Regards
>
> Mishika Singh
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2020-06-15 10:48:46 Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true
Previous Message Khushboo Vashi 2020-06-15 10:22:18 Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables