Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 11:29 AM Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>
>>
>>
>> On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>>
>>>> Awesome!! This is super helpful :)
>>>>
>>>> Does this affect a new query window (currently the title is 'Query -
>>>> untitled')?
>>>>
>>> ​Yes, in this case the title of query window will be Query - [db_name]
>>> on [server_name]. It was showing 'Query - untitled' when opened from
>>> context menu because no tree information was passed.
>>>
>>
>> I know you enabled ellipses for names that are too long, but if it's a
>> database name and server name in a tab, I think that all the tabs will have
>> ellipses. Considering that, what if we just shorten it to the database
>> name, especially since the blue bar where you type the SQL has the name of
>> the server.
>>
> ​Yes ellipses and tooltips are used if name is too long.
> ​But what I think is the title has all useful information about the
> database and server it is connected to, considering the case:
>
> 1) When multiple instances of query tool are opened in New Tab/Window. or
> when a user has multiple screens.
>
> 2) If a user is parallely running multiple instance of query tool for
> different databases of different servers. server name will help uniquely
> identify the tab.
>

My concern is the character limit for tab names will always shorten what a
user will see in the tab, unless the tab has no limit (which I do not think
we should do). Database names might be extremely long.

For example, even if your database name is 'postgres', then there are 20
characters before the server name making the tab really long. [Query -
postgres on server_name]
[image: Screen Shot 2017-06-14 at 10.22.51 AM.png]
Unless they can see the server name quickly, I don't think we're solving
for this use case.

> 3) The panel can be moved out of Panels tab by dragging out, so the panel
> title must have server and database information.
>
> considering the above cases, I think the blue bar could be removed If
> query tool title already have server and database information.
>

something like this?
[image: Screen Shot 2017-06-14 at 10.28.21 AM.png]

Another option: Given that the lightening bolt is an indicator for queries,
is there a need to keep Query in the name?
[image: Screen Shot 2017-06-14 at 10.25.36 AM.png]