Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: Shirley Wang <swang(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title
Date: 2017-06-13 18:28:53
Message-ID: CAM5-9D9G7DnJE0-0M-fki+bB7wL4yrAzgr259Pp+kz-eRXW-Gg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:

>
>
> On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>
>>> Awesome!! This is super helpful :)
>>>
>>> Does this affect a new query window (currently the title is 'Query -
>>> untitled')?
>>>
>> ​Yes, in this case the title of query window will be Query - [db_name]
>> on [server_name]. It was showing 'Query - untitled' when opened from
>> context menu because no tree information was passed.
>>
>
> I know you enabled ellipses for names that are too long, but if it's a
> database name and server name in a tab, I think that all the tabs will have
> ellipses. Considering that, what if we just shorten it to the database
> name, especially since the blue bar where you type the SQL has the name of
> the server.
>
​Yes ellipses and tooltips are used if name is too long.
​But what I think is the title has all useful information about the
database and server it is connected to, considering the case:

1) When multiple instances of query tool are opened in New Tab/Window. or
when a user has multiple screens.

2) If a user is parallely running multiple instance of query tool for
different databases of different servers. server name will help uniquely
identify the tab.

3) The panel can be moved out of Panels tab by dragging out, so the panel
title must have server and database information.

considering the above cases, I think the blue bar could be removed If query
tool title already have server and database information.

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-06-13 23:59:46 Re: Declarative partitioning in pgAdmin4
Previous Message Shirley Wang 2017-06-13 17:54:24 Re: [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title