Re: Style guide live website - looking for feedback

From: Shirley Wang <swang(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Style guide live website - looking for feedback
Date: 2017-06-08 14:41:57
Message-ID: CAPG3WN50HsP81rnPS63m3TcmWtFT0fqufXdK4EHBU=TW-9d11A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

>
>
> Looks good. A couple of thoughts:
>
> - Please use "pgAdmin 4" consistently :-)
>
> Just to clarify - is there always a space between pgAdmin and 4? or is it
pgAdmin4?

> - The neutral message panel has a border that is quite visible, whilst
> the others have much more subtle borders. Seems like something to fix.
>

It is an interesting contrast. I think it should be changed too.

>
> - I think we need some notes on when the different font sizes should be
> used.
>
> Ok. I can start documenting where these fonts are used now, and then we
can think about if that's how we actually want to use them.

> - You've obviously created classes for these styles (e.g. text-14).
> Let's make sure they are all actually defined in the stylesheets for
> the app before we add the style guide :-)
>
> Will do.

> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-08 15:12:13 Re: Style guide live website - looking for feedback
Previous Message Dave Page 2017-06-08 14:25:42 Re: [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server