Re: Style guide live website - looking for feedback

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Shirley Wang <swang(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Style guide live website - looking for feedback
Date: 2017-06-08 15:12:13
Message-ID: CA+OCxozRJD9pU78vK6TyH83eU=HQmwPDdo3Mv90+Y0D6FCwJuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Jun 8, 2017 at 3:41 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>
>> Looks good. A couple of thoughts:
>>
>> - Please use "pgAdmin 4" consistently :-)
>>
> Just to clarify - is there always a space between pgAdmin and 4? or is it
> pgAdmin4?

In natural language text, it's always with a space. The number should
be a numeric (not Roman numerals), and only the A should be
capitalised.

In code etc. the space and capitalisation can be dropped if needed.

>> - The neutral message panel has a border that is quite visible, whilst
>> the others have much more subtle borders. Seems like something to fix.
>
>
> It is an interesting contrast. I think it should be changed too.
>>
>>
>> - I think we need some notes on when the different font sizes should be
>> used.
>>
> Ok. I can start documenting where these fonts are used now, and then we can
> think about if that's how we actually want to use them.
>
>>
>> - You've obviously created classes for these styles (e.g. text-14).
>> Let's make sure they are all actually defined in the stylesheets for
>> the app before we add the style guide :-)
>>
> Will do.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-06-08 15:53:46 Re: [pgAdmin4][Patch]: UI improvements in data-grid/query tool
Previous Message Shirley Wang 2017-06-08 14:41:57 Re: Style guide live website - looking for feedback