Re: Error code for checksum failure in origin.c

On Fri, Aug 27, 2021 at 1:32 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Aug 26, 2021 at 4:11 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> > > On 26 Aug 2021, at 12:03, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > On Thu, Aug 26, 2021 at 3:18 PM Kasahara Tatsuhito
> > > <kasahara(dot)tatsuhito(at)gmail(dot)com> wrote:
> > >>
> > >> Hi.
> > >>
> > >> In the code in src/backend/replication/logical/origin.c,
> > >> the error code "ERRCODE_CONFIGURATION_LIMIT_EXCEEDED" is given
> > >> when a checksum check results in an error,
> > >> but "ERRCODE_ DATA_CORRUPTED" seems to be more appropriate.
> > >>
> > >
> > > +1. Your observation looks correct to me and the error code suggested
> > > by you seems appropriate. We use ERRCODE_DATA_CORRUPTED in
> > > ReadTwoPhaseFile() for similar error.
> >
> > Agreed, +1 for changing this.
> >
>
> I think we need to backpatch this till 9.6 as this is introduced by
> commit 5aa2350426.
+1

Best regards,
--
Tatsuhito Kasahara
kasahara.tatsuhito _at_ gmail.com