Re: ResultCache cache error: "cache entry already complete" in 14beta1

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, David Rowley <drowley(at)postgresql(dot)org>
Subject: Re: ResultCache cache error: "cache entry already complete" in 14beta1
Date: 2021-05-21 14:00:02
Message-ID: CAOxo6XKDDMwBV3co69s_DEfRTXCPqnvkO-sNOR3xV9W19TkzEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, May 20, 2021 at 6:35 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Fri, 21 May 2021 at 11:05, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I'll need to take a bit more time to check if that's a safe way to
> > check if the entire join clause is parameterized or not.
>
> I think it's fine to check the list_length() to see if any quals are
> missing from the param info. This is very similar to what's done
> already in generate_mergejoin_paths() to check if any join quals are
> missing from the merge quals.
>
> I've attached a cleaned-up patch.

I can confirm that this fixes the issue in our case (both in the actual
query and in the minimal reproduction case).

Thanks!

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Yuri Astrakhan 2021-05-21 21:54:16 Re: BUG #16076: JIT causes huge delays in a complex query. jit=off solves it.
Previous Message david 2021-05-21 09:19:21 Re: BUG #17016: Cannot sync pgdg-common repo with reposync due to failed signature check