Re: ResultCache cache error: "cache entry already complete" in 14beta1

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, David Rowley <drowley(at)postgresql(dot)org>
Subject: Re: ResultCache cache error: "cache entry already complete" in 14beta1
Date: 2021-05-20 23:34:59
Message-ID: CAApHDvrWsfc3naVQZxS0efU=vJOA7dG3NV7fGhkgo2=J38OEpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, 21 May 2021 at 11:05, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I'll need to take a bit more time to check if that's a safe way to
> check if the entire join clause is parameterized or not.

I think it's fine to check the list_length() to see if any quals are
missing from the param info. This is very similar to what's done
already in generate_mergejoin_paths() to check if any join quals are
missing from the merge quals.

I've attached a cleaned-up patch.

David

Attachment Content-Type Size
fix_resultcache_singlerow_mode.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robins Tharakan 2021-05-21 02:52:00 Re: BUG #17022: SQL causing engine crash
Previous Message David Rowley 2021-05-20 23:05:21 Re: ResultCache cache error: "cache entry already complete" in 14beta1