Re: [PATCH] Beautify line-ends handling yet more.

As an alternative solution you could do it as Notepad++ does:
Unix/Mac, DOS/Windows, old Mac.

2015-10-10 15:51 GMT+02:00 Dave Page <dpage(at)pgadmin(dot)org>:
>
>
>> On 10 Oct 2015, at 13:33, Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru> wrote:
>>
>> Hello Dave,
>> 09.10.2015 16:31, Dave Page wrote:
>> [...]
>>> I committed a modified version of this - Mac OS X uses \n as a
>>> line-end, so that makes a better default than the old-style \r used on
>>> Mac classic.
>>
>> Ah, I didn't know that, thanks for explanation.
>>
>> I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd propose to also update the corresponding preferences menu. Right now it shows 3 possibilities:
>>
>> * Unix (LF)
>> * DOS (CRLF)
>> * Mac (CR)
>>
>> Maybe it would make sense to only provide 2 with the following naming:
>>
>> * Unix/Mac (LF)
>> * DOS/Windows (CRLF)
>>
>> If it is OK then I'll craft a git diff for that (eventually).
>
> I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive amount of code bloating the app or overly complicating the UI.
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers