From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Beautify line-ends handling yet more. |
Date: | 2015-10-10 13:51:03 |
Message-ID: | 4A470437-1E4F-47E1-ACC8-D42491F5BB31@pgadmin.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
> On 10 Oct 2015, at 13:33, Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru> wrote:
>
> Hello Dave,
> 09.10.2015 16:31, Dave Page wrote:
> [...]
>> I committed a modified version of this - Mac OS X uses \n as a
>> line-end, so that makes a better default than the old-style \r used on
>> Mac classic.
>
> Ah, I didn't know that, thanks for explanation.
>
> I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd propose to also update the corresponding preferences menu. Right now it shows 3 possibilities:
>
> * Unix (LF)
> * DOS (CRLF)
> * Mac (CR)
>
> Maybe it would make sense to only provide 2 with the following naming:
>
> * Unix/Mac (LF)
> * DOS/Windows (CRLF)
>
> If it is OK then I'll craft a git diff for that (eventually).
I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive amount of code bloating the app or overly complicating the UI.
From | Date | Subject | |
---|---|---|---|
Next Message | Nikolai Zhubr | 2015-10-10 14:36:54 | Re: [PATCH] Beautify line-ends handling yet more. |
Previous Message | Nikolai Zhubr | 2015-10-10 12:33:47 | Re: [PATCH] Beautify line-ends handling yet more. |