Re: Add missing PGDLLIMPORT markings

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Rahila Syed <rahilasyed90(at)gmail(dot)com>
Subject: Re: Add missing PGDLLIMPORT markings
Date: 2025-04-09 12:30:40
Message-ID: CAOYmi+mTNV7+fTZsLDDAs5uYORDTJoB57Tswmf1po=b7CyyHGg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 9, 2025 at 4:48 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> -extern const pg_be_sasl_mech pg_be_oauth_mech;
> +extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
> +1 on this.

LGTM, too.

Thanks!
--Jacob

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2025-04-09 12:44:04 Re: Partition pruning on parameters grouped into an array does not prune properly
Previous Message Heikki Linnakangas 2025-04-09 12:26:07 Re: Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c