| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Subject: | Re: Add missing PGDLLIMPORT markings |
| Date: | 2025-04-09 11:48:06 |
| Message-ID: | 68638ACC-3556-429E-93A0-189F73D0E274@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 9 Apr 2025, at 12:02, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
-extern const pg_be_sasl_mech pg_be_oauth_mech;
+extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
+1 on this.
> Btw., this new variable in memutils.h
>
> extern dsa_area *area;
>
> could probably do with a less generic name?
Good point, unless objected to I'll apply the attached renaming which then also
contain the PGDLLIMPORT addition.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-global-variable-backing-DSA-area.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2025-04-09 11:51:10 | Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c |
| Previous Message | Junwang Zhao | 2025-04-09 11:47:57 | Re: Remove unnecessary static type qualifiers |