Re: Memory allocation in spi_printtup()

From: Neil Conway <neil(dot)conway(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memory allocation in spi_printtup()
Date: 2015-08-17 16:22:08
Message-ID: CAOW5sYb+_TgreFdAg_2o-rfXE2WAhU4GZNrhEiKpe4iC0n8KDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 17, 2015 at 7:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Hi Neil! Long time no see.

Likewise :)

>> Attached is a one-liner to double the size of the table when space is
>> exhausted.
>
> I think this could use a comment, but otherwise seems OK.

Attached is a revised patch with a comment.

> Should we back-patch this change? Seems like it's arguably a
> performance bug.

Sounds good to me.

Neil

Attachment Content-Type Size
spi-printtup-alloc-2.patch text/x-patch 528 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-08-17 16:30:56 Re: Raising our compiler requirements for 9.6
Previous Message Bear Giles 2015-08-17 15:36:02 Re: what would tar file FDW look like?