Re: Shouldn't execParallel.c null-terminate query_string in the parallel DSM?

From: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Shouldn't execParallel.c null-terminate query_string in the parallel DSM?
Date: 2017-12-20 07:03:03
Message-ID: CAOGQiiMfPibwV1cxep2dVxSmHc0H+xC0h5QJgBAD6J14zGAeJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 20, 2017 at 7:58 AM, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com
> wrote:

> Hi hackers,
>
> I just saw some trailing garbage in my log file emanating from a
> parallel worker when my query happened to be a BUFFERALIGNed length
> (in this case 64 characters). Did commit 4c728f382970 forget to make
> sure the null terminator is copied? See attached proposed fix.
>
> Yes, I missed that.
Your patch looks good to me, thanks.

--
Regards,
Rafia Sabih
EnterpriseDB: http://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-12-20 07:06:46 Re: User defined data types in Logical Replication
Previous Message Michael Paquier 2017-12-20 06:38:56 Re: TRAP: FailedAssertion("!(TransactionIdPrecedesOrEquals