Shouldn't execParallel.c null-terminate query_string in the parallel DSM?

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Shouldn't execParallel.c null-terminate query_string in the parallel DSM?
Date: 2017-12-20 02:28:26
Message-ID: CAEepm=2SJs7X+_vx8QoDu8d1SMEOxtLhxxLNzZun_BvNkuNhrw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

I just saw some trailing garbage in my log file emanating from a
parallel worker when my query happened to be a BUFFERALIGNed length
(in this case 64 characters). Did commit 4c728f382970 forget to make
sure the null terminator is copied? See attached proposed fix.

--
Thomas Munro
http://www.enterprisedb.com

Attachment Content-Type Size
null-terminate-query-string.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-12-20 02:31:43 Re: Estimate maintenance_work_mem for CREATE INDEX
Previous Message Amit Langote 2017-12-20 02:10:12 Re: Boolean partitions syntax