Reg-[Sonarqube]CodeSmell issues

From: Satish V <satish(dot)v(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Reg-[Sonarqube]CodeSmell issues
Date: 2020-06-16 07:19:02
Message-ID: CAOEjfmH3B9x438-K08kXT+7vLEfDOAq5Gszqf+SFdS34nQi+cQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Please find the patch in the attachment which resolves below issues
1.Replace this if-then-else statement by a single return statement.(clumsy)
2."switch" statements should have at least 3 "case" clauses. (bad practise)
Kindly review and share the changes, if required.

Thanks
Sathish V

Attachment Content-Type Size
switch_case_and_if_else_reduction.patch application/octet-stream 9.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-06-16 09:32:58 pgAdmin 4 commit: Fixed runtime issues reported by SonarQube.
Previous Message Akshay Joshi 2020-06-16 05:46:47 Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube