| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Satish V <satish(dot)v(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reg-[Sonarqube]CodeSmell issues |
| Date: | 2020-06-16 09:33:27 |
| Message-ID: | CANxoLDfz44NvUq_b=TAx1vpHh-U=VAJHkLYs3CxSN6FXQrphpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Tue, Jun 16, 2020 at 12:49 PM Satish V <satish(dot)v(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the patch in the attachment which resolves below issues
> 1.Replace this if-then-else statement by a single return
> statement.(clumsy)
> 2."switch" statements should have at least 3 "case" clauses. (bad
> practise)
> Kindly review and share the changes, if required.
>
>
> Thanks
> Sathish V
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yogesh Mahajan | 2020-06-16 12:21:21 | [pgAdmin4][Patch] - Issue fixes reported by SonarQube -2 |
| Previous Message | Akshay Joshi | 2020-06-16 09:32:58 | pgAdmin 4 commit: Fixed following issues reported by SonarQube: |