From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Subject: | Re: Patch for SonarQube code scan. |
Date: | 2020-06-26 09:05:38 |
Message-ID: | CAOBg0AP5zrZgudvF6ORF1RkbCPDjn6ktBaaDxEHcmrD885op6A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Team,
resolved PEP8 warnings PFA latest patch.
On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please fix PEP8 issues. Other than PEP8, everything looks good to me.
>
> Thanks,
> Khushboo
>
> On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Khushboo,
>>>
>>> Details as follows:
>>> 1. Package files:
>>>
>>> 1. Refactor this function to reduce its Cognitive Complexity from 40 to
>>> the 15 allowed.
>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>> the 15 allowed.
>>>
>>> 2. Functions files:
>>>
>>> 1. Rename this local variable "argString" to match the regular
>>> expression ^[_a-z][a-z0-9_]*$.
>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>> the 15 allowed.
>>>
>>> Thanks,
>>> Nikhil Mohite.
>>>
>>> Thanks.
>>
>>>
>>> On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Nikhil,
>>>>
>>>> Can you please provide the details of the issue provided by SonarQube
>>>> (so review would be easy) ?
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> I have fixed some code smell issues in SonarQube scan.
>>>>> 1. Code smells in packages init file.
>>>>> 2. Code smells in function init file (not fixed all code smell will
>>>>> send new path for it).
>>>>>
>>>>> Regards,
>>>>> Nikhil Mohite.
>>>>>
>>>>>
Attachment | Content-Type | Size |
---|---|---|
sonar_qube_code_smell_fixes.patch | application/octet-stream | 24.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-06-26 09:35:49 | pgAdmin 4 commit: Improve code coverage and API test cases for Domain a |
Previous Message | Khushboo Vashi | 2020-06-26 08:30:26 | Re: Patch for SonarQube code scan. |