From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Subject: | Re: Patch for SonarQube code scan. |
Date: | 2020-06-26 09:37:07 |
Message-ID: | CANxoLDcDHyoQM4mnsZ7fL+DWWOGcU=9KJXOtBhw1kHd5-M=QHQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Jun 26, 2020 at 2:35 PM Nikhil Mohite <
nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
> Hi Team,
>
> resolved PEP8 warnings PFA latest patch.
>
> On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please fix PEP8 issues. Other than PEP8, everything looks good to me.
>>
>> Thanks,
>> Khushboo
>>
>> On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite <
>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Khushboo,
>>>>
>>>> Details as follows:
>>>> 1. Package files:
>>>>
>>>> 1. Refactor this function to reduce its Cognitive Complexity from 40 to
>>>> the 15 allowed.
>>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>>> the 15 allowed.
>>>>
>>>> 2. Functions files:
>>>>
>>>> 1. Rename this local variable "argString" to match the regular
>>>> expression ^[_a-z][a-z0-9_]*$.
>>>> 2. Refactor this function to reduce its Cognitive Complexity from 16 to
>>>> the 15 allowed.
>>>>
>>>> Thanks,
>>>> Nikhil Mohite.
>>>>
>>>> Thanks.
>>>
>>>>
>>>> On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Nikhil,
>>>>>
>>>>> Can you please provide the details of the issue provided by SonarQube
>>>>> (so review would be easy) ?
>>>>>
>>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
>>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>> I have fixed some code smell issues in SonarQube scan.
>>>>>> 1. Code smells in packages init file.
>>>>>> 2. Code smells in function init file (not fixed all code smell will
>>>>>> send new path for it).
>>>>>>
>>>>>> Regards,
>>>>>> Nikhil Mohite.
>>>>>>
>>>>>>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-06-26 09:47:17 | Re: Reg-RM 5326[Code Coverage] Improve API test cases for Domain and Domain Constraints |
Previous Message | Akshay Joshi | 2020-06-26 09:35:49 | pgAdmin 4 commit: Fixed following SonarQube issues: |