| From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Patch for SonarQube code scan fixes. |
| Date: | 2020-07-31 04:15:27 |
| Message-ID: | CAOBg0AOuGXdO-8bx_5KCCG==yxcSbCpmZ6-=XSNyzxGYCDjt3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Team,
I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Utils Route:
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
2. User Management:
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 18 to
the 15 allowed.
3. Query tool preferences:
- Merge these implicitly concatenated strings; or did you forget a comma?
4. Tool Maintenance:
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 20 to
the 15 allowed.
Regards,
Nikhil Mohite.
| Attachment | Content-Type | Size |
|---|---|---|
| SonarQubeCodeSmellFixes.patch | application/octet-stream | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2020-07-31 04:54:16 | Re: WIP: SQL Formatter |
| Previous Message | Dave Page | 2020-07-30 14:52:12 | Re: WIP: SQL Formatter |